Skip to content

Prevent conflicting Runway installations - #6

Merged
Italian-seasoning merged 1 commit into
mainfrom
fix/runway-install-maintenance
Oct 24, 2026
Merged

Italian-seasoning merged 1 commit into
mainfrom
fix/runway-install-maintenance

Conversation

@Italian-seasoning

Copy link
Copy Markdown
Owner

Local installs left older app backups and a legacy alias discoverable by macOS. Archive backups, serialize replacement, preserve rollback, and retire conflicting Runway launch and widget registrations when the installed app reopens.

Validated with 140 macOS tests and six installer checks covering replacement, archival failure, rollback, symlinks, and install locking. Adds macOS CI for both suites.

@Italian-seasoning
Italian-seasoning merged commit cecbbc7 into main Oct 24, 2026
1 check failed
@Italian-seasoning
Italian-seasoning deleted the fix/runway-install-maintenance branch October 24, 2026 05:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T05:30:55.805703Z f32ea5e PR opened
🔒 Security Review ✅ Completed 2026-10-24T05:32:22.695068Z f32ea5e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f32ea5e9a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/install_widget.sh
echo "Could not retire $service" >&2
exit 1
fi
rm -f "$agent"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore refresh-agent plists when installation rolls back

If staging, backup archival, unregistration, or replacement fails after this loop, both refresh-agent plists have already been deleted, but cleanup_build() only restores application bundles. The installer also terminates the running app before these operations and only reopens it on success, so an enabled background-refresh schedule remains disabled after rollback—even across login—until the user manually launches Runway again. The archival-failure fixture reproduces this: the previous app survives, but no agent plists remain and no app is reopened. Preserve the previous agent configuration and restore it on failure along with the application.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant